PHPORM-325 Add getViews and categorize table types
#3327
Conversation
|
Laravel has php artisan db:show --views
$views = Schema::getViews();To follow laravel convention Ill adjust and add getViews |
masterbater
changed the title
src/Schema/Builder.php
Outdated
| foreach ($db->listCollections() as $collectionInfo) { | ||
| $collectionName = $collectionInfo->getName(); | ||
|
|
||
| // Skip system collections |
There was a problem hiding this comment.
The system collections are actual collections. In the case of system.profile, that might actually be something an application would want to query.
I'm not certain it makes sense to exclude these from all output through the integration.
| 'schema_qualified_name' => $db->getDatabaseName() . '.' . $collectionName, | ||
| 'size' => null, | ||
| 'comment' => null, | ||
| 'collation' => null, |
There was a problem hiding this comment.
If this is actually relevant, the information should be available via the options field for each collection info result. See: listCollections
| 'name' => $collectionName, | ||
| 'schema' => $db->getDatabaseName(), | ||
| 'schema_qualified_name' => $db->getDatabaseName() . '.' . $collectionName, | ||
| 'size' => null, |
There was a problem hiding this comment.
If this is relevant, the information can be provided via $collStats (MongoDB 6.2+). I'm not sure that'd be worth the overhead to obtain this for all collections/views, though.
There was a problem hiding this comment.
If someone finds it useful, we can do it, but we'll have to check the impact on performance if there are a lot of collections.
Tracked in PHPORM-326
masterbater
changed the title
|
This is now a simple PR, separating tables(collections in mongodb) and views(standard views). No more segregating SYSTEM collections. For dropAllTables, I followed the recommendation to drop the entire database instead of deleting collections individually. However, this approach may lead to errors, such as "database is in the process of being dropped." While I’m unsure if tthere any production workloads that could affect this, it does cause issues in parallel testing when using the same database—an incorrect setup that should instead use separate databases for each test. |
If the library needs to work around this, it might be sufficient to catch a ServerException and no-op for DatabaseDropPending code 215. I reckon that the original approach to delete collections individually would still be subject to a race condition if a collection was created by another connection between |
- Group collections based on type for better organization - dropAllTables removes database
GromNaN
changed the title
getViews and categorize table types
|
Thank you @masterbater |
Fix #3320
This fixes
db:showandmigrate:freshfor database that has virtual view type collectionsConnection::getViews()php artisan db:show --viewsChecklist